Skip to content

[k2] implement random_int#1607

Open
apolyakov wants to merge 1 commit intomasterfrom
apolyakov/k2-implement-random-int
Open

[k2] implement random_int#1607
apolyakov wants to merge 1 commit intomasterfrom
apolyakov/k2-implement-random-int

Conversation

@apolyakov
Copy link
Copy Markdown
Contributor

No description provided.

@apolyakov apolyakov added this to the next milestone Apr 10, 2026
@apolyakov apolyakov self-assigned this Apr 10, 2026
@apolyakov apolyakov added runtime Feature related to runtime k2 Affects compiler or runtime in K2 mode labels Apr 10, 2026
@apolyakov apolyakov removed the request for review from astrophysik April 10, 2026 12:56
Shamzik
Shamzik previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Contributor

@Shamzik Shamzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding some tests?

@apolyakov
Copy link
Copy Markdown
Contributor Author

What about adding some tests?

There's already dl/386_random_int.php

@apolyakov apolyakov force-pushed the apolyakov/k2-implement-random-int branch from f69eb71 to 54bf451 Compare April 10, 2026 14:51
@apolyakov apolyakov requested a review from Shamzik April 10, 2026 14:52
@Shamzik
Copy link
Copy Markdown
Contributor

Shamzik commented Apr 10, 2026

What about adding some tests?

There's already dl/386_random_int.php

Can we remove the "php8" tag?

Shamzik
Shamzik previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Contributor

@Shamzik Shamzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@apolyakov apolyakov force-pushed the apolyakov/k2-implement-random-int branch from a2d57a7 to 54bf451 Compare April 10, 2026 15:33
@apolyakov apolyakov requested a review from Shamzik April 10, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k2 Affects compiler or runtime in K2 mode runtime Feature related to runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants