Skip to content

fix: inherit selected model in slide tools#65

Closed
nicko-ai wants to merge 1 commit into
mainfrom
codex/os-models-slides-model-inheritance
Closed

fix: inherit selected model in slide tools#65
nicko-ai wants to merge 1 commit into
mainfrom
codex/os-models-slides-model-inheritance

Conversation

@nicko-ai

Copy link
Copy Markdown
Collaborator

Summary

  • Make the Slides planner and HTML writer inherit the selected/request model instead of choosing their own fallback.
  • Preserve Codex/OpenAI client settings for gpt-5.4-mini and openai/... models.
  • Keep OpenRouter, Ollama, Anthropic, and LiteLLM-style routes on LiteLLM without OpenAI-only settings.

Checks

  • python -m pytest tests/test_slides_internal_models.py -q
  • PYTHONPYCACHEPREFIX="$tmp" python -m compileall -q slides_agent/tools/internal_model.py slides_agent/tools/InsertNewSlides.py slides_agent/tools/ModifySlide.py tests/test_slides_internal_models.py
  • git diff --check

- route Slides planner and HTML writer through the caller-selected model

- preserve Codex/OpenAI client settings and LiteLLM provider routes

- cover gpt-5.4-mini, openai-prefixed, OpenRouter, and Ollama-style paths
@nicko-ai

Copy link
Copy Markdown
Collaborator Author

Closing as a duplicate draft. The replacement path is PR #68.

@nicko-ai nicko-ai closed this Jun 21, 2026
@nicko-ai nicko-ai deleted the codex/os-models-slides-model-inheritance branch June 23, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant