Fix Scout LongDistanceRunner achievement not counting distance on round end#1860
Open
qequ wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fix Scout LongDistanceRunner achievement not counting distance on round end#1860qequ wants to merge 1 commit intoValveSoftware:masterfrom
qequ wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
…nd end The handler for teamplay_round_win existed but the event was never registered in ListenForEvents(), making it dead code. Distance ran during a life that ended via round win/loss was silently lost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CAchievementTFScout_LongDistanceRunner achievement ("Race for the Pennant") has a bug where distance progress is lost when a round ends without the player dying.
The FireGameEvent_Internal handler already has a branch for teamplay_round_win, but the event was never registered in ListenForEvents() making it dead code since the initial SDK commit. The m_fMetersRan counter resets on respawn (c_tf_player.cpp:7953), so any distance accumulated during a life that ends via round win/loss is silently discarded.
Fix
Added ListenForGameEvent( "teamplay_round_win" ) to ListenForEvents() so the existing handler is actually reached.