Skip to content

fix: move default user creation to first-setup - #422

Open
FangcatChina wants to merge 1 commit into
Vanilla-OS:mainfrom
FangcatChina:main
Open

fix: move default user creation to first-setup#422
FangcatChina wants to merge 1 commit into
Vanilla-OS:mainfrom
FangcatChina:main

Conversation

@FangcatChina

@FangcatChina FangcatChina commented Oct 4, 2026

Copy link
Copy Markdown
Member

Should be merged along with #489 in vanilla-installer.

Discussion: https://github.com/orgs/Vanilla-OS/discussions/432

@FangcatChina FangcatChina changed the title fix: move user creation to first-setup fix: move default user creation to first-setup Oct 4, 2026
@FangcatChina FangcatChina mentioned this pull request Oct 4, 2026
Open
@FangcatChina
FangcatChina force-pushed the main branch 2 times, most recently from 7cb9e4e to be94deb Compare October 6, 2026 02:47
NN708
NN708 requested changes Oct 9, 2026
View reviewed changes

@NN708 NN708 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think creating a user with a hardcoded password is a good practice. A better approach might be to create a group using systemd-sysusers, similar to what gnome-initial-setup does: https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/blob/main/data/gnome-initial-setup.conf

@FangcatChina

FangcatChina commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

I don't think creating a user with a hardcoded password is a good practice. A better approach might be to create a group using systemd-sysusers, similar to what gnome-initial-setup does: https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/blob/main/data/gnome-initial-setup.conf

Great idea. That's also what plasma-setup does (https://invent.kde.org/plasma/plasma-setup/-/blob/master/files/plasma-setup-sysuser.conf). I'll edit it later.

@FangcatChina

FangcatChina commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I referred to plasma-setup to adopt the changes.

Tested on Debian 13 hundreds of times until I found out that even the released one didn't work on it either.😂

@FangcatChina
FangcatChina requested a review from NN708 October 12, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jardon jardon jardon approved these changes
@NN708 NN708 Awaiting requested review from NN708

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FangcatChina @jardon @NN708