Skip to content

🐞 Fix groupSum sorting - #1557

Merged
atarpara merged 1 commit into
mainfrom
fix-sort
Sep 1, 2026
Merged

atarpara merged 1 commit into
mainfrom
fix-sort

Conversation

@atarpara

Copy link
Copy Markdown
Collaborator

Description

Describe the changes made in your pull request here.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions

Copy link
Copy Markdown

Gas Snapshot Comparison Report

Generated at commit : e03a631, Compared to commit : 4225d5f

Contract Name Test Name Main Gas PR Gas Diff
LibSortTest testHasDuplicateGas() 769174 769634 460
testInsertionSortInts() 79950 79973 23
testInsertionSortPsuedorandom() 63575 63553 -22
testSearchSorted() 118046 118069 23
testSearchSortedBasicCases() 2200 2178 -22
testSearchSortedInts() 120090 120068 -22
testSearchSortedWithEmptyArray() 677 721 44
testSortAddressesReversed() 45497 45520 23
testSortAddressesSorted() 41133 41176 43
testSortInts() 887851 887873 22
testSortMostlySame() 65989 65967 -22
testSortOriginalMostlySame() 207254 207232 -22
testSortOriginalSorted() 141663 141641 -22
testSortPsuedorandom() 140092 140070 -22
testSortSorted() 34541 34564 23
testSortTestOverhead() 103279 103257 -22
testSortedDifferenceDifferential() 182422 182399 -23
testSortedIntersectionDifferential() 208346 208324 -22
testUniquifySorted() 1703 1660 -43
testUniquifySortedAddress() 4010 4032 22
testUniquifySortedWithEmptyArray() 545 523 -22
test__codesize() 25386 26730 1344
testGroupSumSigned() - 6156 -

@atarpara
atarpara merged commit 35d8c9c into main Sep 1, 2026
14 checks passed
@atarpara
atarpara deleted the fix-sort branch September 2, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant