Consumers can now request private keys (for SSH certificates) protected by a passphrase#264
Open
achuchev wants to merge 1 commit intoVenafi:masterfrom
Open
Consumers can now request private keys (for SSH certificates) protected by a passphrase#264achuchev wants to merge 1 commit intoVenafi:masterfrom
achuchev wants to merge 1 commit intoVenafi:masterfrom
Conversation
Contributor
achuchev
commented
Oct 7, 2022
- The PrivateKeyPassphrase attribute was missing, so consumers cannot request private keys protected by a passphrase.
- Remove PrivateKeyFormat from the SSH cert data structure. This option has never been implemented on the server side.
Remove PrivateKeyFormat from the SSH cert data structure. This option was never implemented on the server side.
Contributor
|
Changes looks good @achuchev , could you add a unit test for this? |
Contributor
Author
|
@luispresuelVenafi Do you mind to point me where I can find similar tests? |
Contributor
|
Sure @achuchev, you could take this test as an example: https://github.com/Venafi/vcert/blob/master/pkg/venafi/tpp/connector_test.go#L2107 You could do the following tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.