CodeRabbit Generated Unit Tests: Add unit tests for PR changes

[coderabbitai]

Unit test generation was requested by @koder95.

• Decouple request sending and response deserialization for login (RequestAgent + ResponseDeserializer) #3 (comment)

The following files were modified:

• src/test/java/pl/vtt/wpi/core/application/service/impl/LoginServiceImplTest.java
• src/test/java/pl/vtt/wpi/core/domain/model/ResponseTest.java

[coderabbitai]

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e64b4fd6-4c3a-49ae-bbf2-7965c9ad4855

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[koder95]

@coderabbitai Tests do not working. Compilation failures was found.

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

Let me inspect the test files and source files to identify the compilation failures.

---

🏁 Script executed:

#!/bin/bash
echo "=== Test Files ==="
fd -e java . src/test --exec cat {}

echo ""
echo "=== Source Files ==="
fd -e java . src/main --exec cat {}

Length of output: 28024

---

@koder95: After inspecting the source and test files, I've identified several root causes for the compilation failures. The generated tests were written against an API that either doesn't exist yet or differs from the actual implementation. Here's a full breakdown:

---

🔴 Missing classes (referenced in tests but not in source)

Class	Used in test	Status
pl.vtt.wpi.core.application.exception.DeserializationException	DeserializationExceptionTest, LoginServiceImplTest	❌ Not found
pl.vtt.wpi.core.application.util.RequestAgent	LoginServiceImplTest	❌ Not found
pl.vtt.wpi.core.application.util.ResponseDeserializer	LoginServiceImplTest	❌ Not found
pl.vtt.wpi.core.application.util.ResponseProxy	LoginServiceImplTest	❌ Not found
pl.vtt.wpi.core.domain.model.Response (with body() throwing semantics)	ResponseTest, LoginServiceImplTest	❌ Not found

---

🔴 LoginServiceImpl — constructor mismatch

The tests call constructors that don't exist:

Test expects (4-arg):

new LoginServiceImpl(null, AuthorizationHolder::get, requestAgent, responseDeserializer)

Test expects (3-arg with different types):

new LoginServiceImpl(new RequestFactory<>() {}, _ -> () -> new Response(...), new ResponseDeserializer() {...})

Actual constructors in source:

// deprecated
LoginServiceImpl(RequestFactory<Void>, RequestHandler<Void, Credentials>)

// active
LoginServiceImpl(String url, Supplier<Authorization>, RequestHandler<Void, Credentials>)

The tests assume LoginServiceImpl accepts RequestAgent and ResponseDeserializer — types which don't exist in the codebase.

---

🔴 module-info.java — missing test access

The current module-info.java does not open packages to JUnit's reflection. If running as a named module, you'll also need:

opens pl.vtt.wpi.core.application.service.impl to org.junit.platform.commons;
opens pl.vtt.wpi.core.application.exception to org.junit.platform.commons;
opens pl.vtt.wpi.core.domain.model to org.junit.platform.commons;

---

✅ Recommended fix

The tests were generated anticipating a refactored API. You have two options:

1. Implement the missing classes (DeserializationException, RequestAgent, ResponseDeserializer, ResponseProxy, Response) and add the corresponding constructor to LoginServiceImpl — effectively completing the refactoring that PR #3 started.

2. Rewrite the tests to match the current API — using RequestHandler<Void, Credentials> directly and removing references to the non-existent types.

Would you like me to rewrite the tests to match the current source API, or help scaffold the missing classes to make the intended API compile?