Repository navigation
Give a slow exchange's test more room on a busy pool - #1005
Merged
Merged
Conversation
ASlowExchangeDoesNotBlockTheNext failed on net48 in CI (#1000's windows job): the second exchange went unanswered within ten seconds, and the first had taken eight to reach its handler, in a process started seconds before beside four other test assemblies. That is the thread pool, not the server. The hold is sixty seconds and the second exchange thirty. What is asserted is unchanged: an answer inside any timeout shorter than the hold shows the second exchange was not waiting on the first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASlowExchangeDoesNotBlockTheNextfailed on net48 in thewindowsjob of #1000, which touches nothing it tests.What happened. The second exchange went unanswered within its ten seconds. The first had already taken about eight seconds to reach its handler, which needs only one background task and one connection. The net48 test process had started seconds before, beside four other test assemblies. So the thread pool was starved, and the server was not the problem.
The change. The hold goes from 30 to 60 seconds and the second exchange from 10 to 30. What is asserted is unchanged: an answer inside any timeout shorter than the hold shows the second exchange was not waiting on the first. A passing run takes no longer than before, since the hold is released as soon as the second exchange is answered.
Tests. The test passes on net48 and net10.0 locally.