Repository navigation
Take the native runtime from PlatformHeads - #967
Merged
Merged
Conversation
The window, GLFW's input, the frame skipping, the renderer, the fonts and the label helpers of deview.cpp move to PlatformHeads' native runtime, which BuildMonitor takes too, and deview.cpp calls them as ph::. A placement handed over now also places a window started hidden. The AppKit head takes PlatformHeadsMac the same way: HeadWindow, EventPump, TerminateGuard, NapGuard, KnobScroller (which was PaneScroller), ScrollerTravel, WheelNotches, ToolTipRegions, StringBlob, Capture, Clipboard and WindowPlacement. A placement is now measured from the top left of the primary screen, as every other head measures it, so a window left by an older viewer opens once where its old bottom-left numbers say. CMake and SwiftPM point at the PlatformHeads branch until it is tagged 0.4.0.
All six pins, off the native-runtime branch the adoption was checked against.
Co-authored-by: SimonCropp <122666+SimonCropp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes PlatformHeads layer 4, the native runtime (SimonCropp/PlatformHeads#1, tagged 0.4.0).
ph::for the window, GLFW's input, which frames are built and drawn, the renderer, the fonts and the label helpers, where it had its own copy.PlatformHeadsMacforHeadWindow,EventPump,TerminateGuard,NapGuard,KnobScroller,ScrollerTravel,WheelNotches,ToolTipRegions,StringBlob,Capture,ClipboardandWindowPlacement.All six PlatformHeads pins are at 0.4.0: the workflow's
uses:, CMake'sGIT_TAG, the three packages inDirectory.Packages.props, and the newPlatformHeadspackage innative/swift/Package.swift. The committed binaries follow in the PRbuild-nativeopens.