Fix Excel conversion on cell-less (hidden) rows#130
Merged
Conversation
A hidden row is emitted as an empty <row/> with no cells. Two code paths
mishandled it when it was the first row in a sheet:
- The CSV builder ran `builder.Length -= 1` to trim a trailing comma that
was never appended, throwing ArgumentOutOfRangeException ("value ('-1')
must be a non-negative value").
- GetColumnInfos picked the empty row as the header and surfaced no
columns (also skewing the rich-text/note lookups keyed to the header
row index).
Both now skip rows with no cells. Adds the HiddenRow sample/test ported
from Verify.ClosedXml, plus a GetColumnInfos unit test for the header fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hidden row is emitted as an empty with no cells. Two code paths mishandled it when it was the first row in a sheet:
builder.Length -= 1to trim a trailing comma that was never appended, throwing ArgumentOutOfRangeException ("value ('-1') must be a non-negative value").Both now skip rows with no cells. Adds the HiddenRow sample/test ported from Verify.ClosedXml, plus a GetColumnInfos unit test for the header fix.