Skip to content

Resolve issues #2, #11, #15, #16, #22, #34#85

Open
MicD746 wants to merge 2 commits into
VertexChainLabs:mainfrom
MicD746:micd746/resolve-2-11-15-16-22-34
Open

Resolve issues #2, #11, #15, #16, #22, #34#85
MicD746 wants to merge 2 commits into
VertexChainLabs:mainfrom
MicD746:micd746/resolve-2-11-15-16-22-34

Conversation

@MicD746

@MicD746 MicD746 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Resolves all 6 open issues owned by MicD746 in one batch.

Verification

  • npx tsc --noEmit (strict TS) → clean
  • npm run build → clean

MicD746 added 2 commits June 23, 2026 12:32
…ertexChainLabs#15 VertexChainLabs#16 VertexChainLabs#22 VertexChainLabs#34

- VertexChainLabs#2 security: remove hardcoded DB password defaults in configuration
  - configuration.ts, data-source.ts, database.module.ts: drop fallback
    credentials for DATABASE_USER/PASSWORD/NAME
  - main.ts: add pre-flight check that throws before NestFactory.create
    when required DB env vars are missing
- VertexChainLabs#11 security: add Helmet HTTP security headers middleware
  - main.ts: import helmet@^8.2.0 and apply globally before other middleware
- VertexChainLabs#15 security: cap JSON/urlencoded request body size
  - main.ts: app.useBodyParser with default 100kb, override via MAX_BODY_SIZE
- VertexChainLabs#16 security: per-IP rate limiting differentiation
  - app.module.ts: ThrottlerModule with THROTTLE_TTL_MS / THROTTLE_LIMIT
    driven config; global ThrottlerGuard via APP_GUARD (default tracks by
    req.ip); per-route @Throttle / @SkipThrottle on gists controller
  - main.ts: app.set("trust proxy", TRUST_PROXY) before middleware so
    X-Forwarded-For is honored behind ALB / nginx / Cloudflare
  - auth-vs-anon differentiation deferred to Issue VertexChainLabs#3
- VertexChainLabs#22 refactor: enable strict TypeScript checks in Backend
  - tsconfig.json: strictNullChecks, noImplicitAny, strictBindCallApply,
    forceConsistentCasingInFileNames, noFallthroughCasesInSwitch enabled
  - strictPropertyInitialization left disabled with rationale comment
    (NestJS constructor injection without explicit `!`)
- VertexChainLabs#34 ci: Dependabot configuration for automated dependency PRs
  - .github/dependabot.yml: weekly Monday checks for npm Backend/Frontend/
    analytics, cargo contracts, and github-actions, grouped minor/patch
    updates with `dependencies` + `automation` labels
  - infrastructure/ci/dependency-updates.yml: schedule disabled to avoid
    duplicate weekly PRs alongside Dependabot (manual workflow_dispatch
    retained for emergencies)

Closes VertexChainLabs#2, VertexChainLabs#11, VertexChainLabs#15, VertexChainLabs#16, VertexChainLabs#22, VertexChainLabs#34

Copy link
Copy Markdown
Contributor

Hey @MicD746 👋 Really appreciate the breadth of fixes bundled here — tackling #2, #11, #15, #16, #22, and #34 in one go is ambitious. However, CI is currently failing on two checks on this PR: the Backend (NestJS) job and the Validate PR title (Conventional Commits) lint (the current title Resolve issues #2, #11, #15, #16, #22, #34 isn’t Conventional-Commits-friendly).

A couple of options if you’d like to keep the bundle: (1) retitle the PR with a Conventional Commits prefix (e.g. chore: address security and tooling issues (#2, #11, #15, #16, #22, #34)), and (2) push a backend fix so the NestJS job goes green. Happy to merge this across all of those issues once everything is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment