Parser: support MSVC-style fixed-size integer suffixes#985
Open
ehaas wants to merge 1 commit intoVexu:masterfrom
Open
Parser: support MSVC-style fixed-size integer suffixes#985ehaas wants to merge 1 commit intoVexu:masterfrom
ehaas wants to merge 1 commit intoVexu:masterfrom
Conversation
Vexu
reviewed
Mar 15, 2026
| pub fn parseNumberToken(p: *Parser, tok_i: TokenIndex) !Result { | ||
| const buf = p.tokSlice(tok_i); | ||
| const prefix = NumberPrefix.fromString(buf); | ||
| const is_msvc = p.comp.langopts.emulate == .msvc; |
Owner
There was a problem hiding this comment.
Clang allows these suffixes with -fms-extensions.
Collaborator
Author
There was a problem hiding this comment.
Upon looking into this more, it looks like clang (I tested x86_64) with ms-extensions treats __int64 as long long, but an i64 literal as int64_t (long). On x86-64 MSVC __int64 and int64_t are both long long so it doesn't matter. So basically it looks like those literals will need to use the platform-specific int64_t type. i8 suffix on the other hand uses char (same as __int8), whereas int8_t is signed char. I'll have to dig into this more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #956