Skip to content

Update VelocityUtil.java (Round instead of truncating in toLegacyVelocity) #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 1 commit into from
Jun 12, 2026
+5 −1
Merged

Update VelocityUtil.java (Round instead of truncating in toLegacyVelocity) #1272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/src/main/java/com/viaversion/viabackwards/utils/VelocityUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
public class VelocityUtil {

public static short toLegacyVelocity(double value) {
return (short) Math.max(Short.MIN_VALUE, Math.min(Short.MAX_VALUE, (long) (value * 8000)));
// Round instead of truncating toward zero. The 1.21.9+ LP-vector encoding is lossy: 0.4 b/t
// decodes as 0.39998779, and (long)(value * 8000) floors that to 3199 instead of 3200. Rounding
// restores the intended legacy short and matches a native 1.8 server, which sends 0.4 directly
// as (int)(0.4 * 8000) = 3200.
return (short) Math.max(Short.MIN_VALUE, Math.min(Short.MAX_VALUE, Math.round(value * 8000)));
}

}