Skip to content

Fix resource pack loading #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RaphiMC merged 1 commit into from
Oct 18, 2026
Merged

Fix resource pack loading #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/net/raphimc/viabedrock/protocol/packet/ResourcePackPackets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ public static void register(final BedrockProtocol protocol) {
final ResourcePackDownloadTracker downloadTracker = wrapper.user().get(ResourcePackDownloadTracker.class);
final ResourcePackDownloadTracker.Download download = downloadTracker.get(key);
if (download != null) {
ViaBedrock.getPlatform().getLogger().log(Level.INFO, "Downloading resource pack chunk " + chunk + "/" + download.chunkSize() + " for " + key);
final ResourcePack resourcePack = download.processDataChunk(chunk, data);
if (resourcePack != null) {
downloadTracker.remove(key);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/raphimc/viabedrock/protocol/storage/ResourcePackLoadStateTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public CompletableFuture<Void> loadRequestedResourcePacks() {
final PacketWrapper resourcePackClientResponse = PacketWrapper.create(ServerboundBedrockPackets.RESOURCE_PACK_CLIENT_RESPONSE, this.user());
resourcePackClientResponse.write(BedrockTypes.UNSIGNED_VAR_INT, ResourcePackResponse.Downloading.getValue()); // status
resourcePackClientResponse.write(BedrockTypes.STRING, "downloading"); // #blameMojang
resourcePackClientResponse.write(BedrockTypes.SHORT_LE_STRING_ARRAY, downloadList.stream().map(ResourcePack.Key::toString).toArray(String[]::new)); // downloading packs
resourcePackClientResponse.write(BedrockTypes.STRING_ARRAY, downloadList.stream().map(ResourcePack.Key::toString).toArray(String[]::new)); // downloading packs
resourcePackClientResponse.scheduleSendToServer(BedrockProtocol.class);
} else {
this.loadFuture.complete(null);
Expand Down
1 change: 0 additions & 1 deletion src/main/java/net/raphimc/viabedrock/protocol/types/BedrockTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public final class BedrockTypes {
public static final Type<String> ASCII_STRING = new AsciiStringType();
public static final Type<String> STRING = new StringType();
public static final Type<String> OPTIONAL_STRING = new OptionalType<>(STRING);
public static final Type<String[]> SHORT_LE_STRING_ARRAY = new ArrayType<>(STRING, SHORT_LE);
public static final Type<String[]> STRING_ARRAY = new ArrayType<>(STRING, UNSIGNED_VAR_INT);
public static final Type<String> UTF8_STRING = new Utf8StringType();
public static final Type<String[]> UTF8_STRING_ARRAY = new ArrayType<>(UTF8_STRING, UNSIGNED_INT_LE);
Expand Down