DRAFT: Feature: compatibility with drawille-rs crate#13
Draft
VincentFoulon80 wants to merge 2 commits intomasterfrom
Draft
DRAFT: Feature: compatibility with drawille-rs crate#13VincentFoulon80 wants to merge 2 commits intomasterfrom
VincentFoulon80 wants to merge 2 commits intomasterfrom
Conversation
This was referenced Oct 31, 2021
dbdf804 to
b93625f
Compare
This was referenced May 5, 2022
Owner
Author
|
I'll postpone this PR a bit, since the drawille crate got a new maintainer, I think this need a bit more time to decide how to link these crates together properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged, this branch will add two new features :
compatibility: this feature will expose a traitAsScreenthat'll allow anybody to implement a method to convert its object to aScreen, allowing compatibility with external crates and custom structurescompatibility-drawille: This feature will bridge a compatibility layer betweenconsole_engineanddrawille-rs.The new
AsScreentrait can also be used for direct drawing of any compatible structure with two new methodsprint_withandprint_alpha_with.