Skip to content

EGLBE: Support additional named framebuffer functions #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tahmid-23 wants to merge 2 commits into
base: main
Choose a base branch
from
+596 −32
Open

EGLBE: Support additional named framebuffer functions #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73e6ad3
EGLBE: Support additional named framebuffer functions
tahmid-23 Jul 1, 2026
ae4c01c
add copyright attribution
tahmid-23 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
280 changes: 248 additions & 32 deletions server/backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Copyright (C)2019-2023, 2025 D. R. Commander
// Copyright (C)2026 Tahmid Zaman
//
// This library is free software and may be redistributed and/or modified under
// the terms of the wxWindows Library License, Version 3.1 or (at your option)
Expand Down Expand Up @@ -65,6 +66,16 @@ static FakePbuffer *getCurrentFakePbuffer(EGLint readdraw)
}


static void resolveDefaultFB(GLuint &framebuffer, EGLint readdraw = EGL_DRAW)
{
FakePbuffer *pb;
if(framebuffer == 0
&& (pb = PBHASHEGL.find(readdraw == EGL_READ ?
getCurrentReadDrawableEGL() : getCurrentDrawableEGL())) != NULL)
framebuffer = pb->getFBO();
}


void bindFramebuffer(GLenum target, GLuint framebuffer, bool ext)
{
const GLenum *oldDrawBufs = NULL; GLsizei nDrawBufs = 0;
Expand Down Expand Up @@ -144,6 +155,62 @@ void deleteFramebuffers(GLsizei n, const GLuint *framebuffers)
}


void blitNamedFramebuffer(GLuint readFramebuffer, GLuint drawFramebuffer,
GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, GLint dstX0, GLint dstY0,
GLint dstX1, GLint dstY1, GLbitfield mask, GLenum filter)
{
if(fconfig.egl)
{
resolveDefaultFB(readFramebuffer, EGL_READ);
resolveDefaultFB(drawFramebuffer, EGL_DRAW);
}
_glBlitNamedFramebuffer(readFramebuffer, drawFramebuffer, srcX0, srcY0, srcX1,
srcY1, dstX0, dstY0, dstX1, dstY1, mask, filter);
}


GLenum checkNamedFramebufferStatus(GLuint framebuffer, GLenum target, bool ext)
{
if(fconfig.egl)
resolveDefaultFB(framebuffer,
target == GL_READ_FRAMEBUFFER ? EGL_READ : EGL_DRAW);
if(ext) return _glCheckNamedFramebufferStatusEXT(framebuffer, target);
else return _glCheckNamedFramebufferStatus(framebuffer, target);
}


void clearNamedFramebufferfi(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, GLfloat depth, GLint stencil)
{
if(fconfig.egl) resolveDefaultFB(framebuffer);
_glClearNamedFramebufferfi(framebuffer, buffer, drawbuffer, depth, stencil);
}


void clearNamedFramebufferfv(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, const GLfloat *value)
{
if(fconfig.egl) resolveDefaultFB(framebuffer);
_glClearNamedFramebufferfv(framebuffer, buffer, drawbuffer, value);
}


void clearNamedFramebufferiv(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, const GLint *value)
{
if(fconfig.egl) resolveDefaultFB(framebuffer);
_glClearNamedFramebufferiv(framebuffer, buffer, drawbuffer, value);
}


void clearNamedFramebufferuiv(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, const GLuint *value)
{
if(fconfig.egl) resolveDefaultFB(framebuffer);
_glClearNamedFramebufferuiv(framebuffer, buffer, drawbuffer, value);
}


GLXContext createContext(Display *dpy, VGLFBConfig config, GLXContext share,
Bool direct, const int *glxAttribs)
{
Expand Down Expand Up @@ -531,6 +598,41 @@ int getFBConfigAttrib(Display *dpy, VGLFBConfig config, int attribute,
}


static bool mapDefaultFBAttachment(FakePbuffer *pb, GLenum &attachment)
{
switch(attachment)
{
case GL_FRONT_LEFT:
attachment = GL_COLOR_ATTACHMENT0; return true;
case GL_FRONT_RIGHT:
attachment = GL_COLOR_ATTACHMENT2; return true;
case GL_BACK_LEFT:
attachment = GL_COLOR_ATTACHMENT1; return true;
case GL_BACK_RIGHT:
attachment = GL_COLOR_ATTACHMENT3; return true;
case GL_DEPTH:
{
VGLFBConfig config = pb->getFBConfig();
if(config->attr.stencilSize && config->attr.depthSize)
attachment = GL_DEPTH_STENCIL_ATTACHMENT;
else
attachment = GL_DEPTH_ATTACHMENT;
return true;
}
case GL_STENCIL:
{
VGLFBConfig config = pb->getFBConfig();
if(config->attr.stencilSize && config->attr.depthSize)
attachment = GL_DEPTH_STENCIL_ATTACHMENT;
else
attachment = GL_STENCIL_ATTACHMENT;
return true;
}
}
return false;
}


void getFramebufferAttachmentParameteriv(GLenum target, GLenum attachment,
GLenum pname, GLint *params)
{
Expand All @@ -552,43 +654,14 @@ void getFramebufferAttachmentParameteriv(GLenum target, GLenum attachment,
&& (pb = getCurrentFakePbuffer(EGL_DRAW)) != NULL)
|| (target == GL_READ_FRAMEBUFFER
&& (pb = getCurrentFakePbuffer(EGL_READ)) != NULL))
{
switch(attachment)
{
case GL_FRONT_LEFT:
attachment = GL_COLOR_ATTACHMENT0; isDefault = true; break;
case GL_FRONT_RIGHT:
attachment = GL_COLOR_ATTACHMENT2; isDefault = true; break;
case GL_BACK_LEFT:
attachment = GL_COLOR_ATTACHMENT1; isDefault = true; break;
case GL_BACK_RIGHT:
attachment = GL_COLOR_ATTACHMENT3; isDefault = true; break;
case GL_DEPTH:
{
VGLFBConfig config = pb->getFBConfig();
if(config->attr.stencilSize && config->attr.depthSize)
attachment = GL_DEPTH_STENCIL_ATTACHMENT;
else
attachment = GL_DEPTH_ATTACHMENT;
isDefault = true; break;
}
case GL_STENCIL:
{
VGLFBConfig config = pb->getFBConfig();
if(config->attr.stencilSize && config->attr.depthSize)
attachment = GL_DEPTH_STENCIL_ATTACHMENT;
else
attachment = GL_STENCIL_ATTACHMENT;
isDefault = true; break;
}
}
}
isDefault = mapDefaultFBAttachment(pb, attachment);
}
}
_glGetFramebufferAttachmentParameteriv(target, attachment, pname, params);
if(fconfig.egl)
{
if(isDefault && *params == GL_RENDERBUFFER)
if(isDefault && pname == GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
&& *params == GL_RENDERBUFFER)
*params = GL_FRAMEBUFFER_DEFAULT;
}
}
Expand Down Expand Up @@ -625,6 +698,37 @@ void getFramebufferParameteriv(GLenum target, GLenum pname, GLint *params)
}


void getFramebufferParameterivEXT(GLuint framebuffer, GLenum pname,
GLint *params)
{
if(fconfig.egl)
{
if(!params)
{
_glGetFramebufferParameterivEXT(framebuffer, pname, params);
return;
}
FakePbuffer *pb;
if(framebuffer == 0
&& (pb = PBHASHEGL.find(getCurrentDrawableEGL())) != NULL)
{
if(pname == GL_DOUBLEBUFFER)
{
*params = pb->getFBConfig()->attr.doubleBuffer;
return;
}
else if(pname == GL_STEREO)
{
*params = pb->getFBConfig()->attr.stereo;
return;
}
else framebuffer = pb->getFBO();
}
}
_glGetFramebufferParameterivEXT(framebuffer, pname, params);
}


void getIntegerv(GLenum pname, GLint *params)
{
if(fconfig.egl)
Expand Down Expand Up @@ -740,6 +844,118 @@ void getNamedFramebufferParameteriv(GLuint framebuffer, GLenum pname,
}


void getNamedFramebufferAttachmentParameteriv(GLuint framebuffer,
GLenum attachment, GLenum pname, GLint *params, bool ext)
{
bool isDefault = false;

if(fconfig.egl)
{
if(!params)
{
if(ext)
_glGetNamedFramebufferAttachmentParameterivEXT(framebuffer,
attachment, pname, params);
else
_glGetNamedFramebufferAttachmentParameteriv(framebuffer, attachment,
pname, params);
return;
}
FakePbuffer *pb;
if(framebuffer == 0
&& (pb = PBHASHEGL.find(getCurrentDrawableEGL())) != NULL)
{
if((attachment >= GL_FRONT_LEFT && attachment <= GL_BACK_RIGHT)
|| (attachment >= GL_DEPTH && attachment <= GL_STENCIL))
isDefault = mapDefaultFBAttachment(pb, attachment);
framebuffer = pb->getFBO();
}
}
if(ext)
_glGetNamedFramebufferAttachmentParameterivEXT(framebuffer, attachment,
pname, params);
else
_glGetNamedFramebufferAttachmentParameteriv(framebuffer, attachment, pname,
params);
if(fconfig.egl)
{
if(isDefault && params && pname == GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE
&& *params == GL_RENDERBUFFER)
*params = GL_FRAMEBUFFER_DEFAULT;
}
}


static GLenum *mapInvalidateAttachments(FakePbuffer *pb,
GLsizei numAttachments, const GLenum *attachments)
{
if(numAttachments <= 0 || !attachments) return NULL;
VGLFBConfig config = pb->getFBConfig();
bool combined = (config->attr.stencilSize && config->attr.depthSize);
GLenum *out = new GLenum[numAttachments];
for(GLsizei i = 0; i < numAttachments; i++)
{
switch(attachments[i])
{
case GL_COLOR: out[i] = GL_COLOR_ATTACHMENT0; break;
case GL_DEPTH:
out[i] = combined ? GL_DEPTH_STENCIL_ATTACHMENT : GL_DEPTH_ATTACHMENT;
break;
case GL_STENCIL:
out[i] = combined ? GL_DEPTH_STENCIL_ATTACHMENT :
GL_STENCIL_ATTACHMENT;
break;
default: out[i] = attachments[i]; break;
}
}
return out;
}


void invalidateNamedFramebufferData(GLuint framebuffer, GLsizei numAttachments,
const GLenum *attachments)
{
GLenum *mapped = NULL;

if(fconfig.egl)
{
FakePbuffer *pb;
if(framebuffer == 0
&& (pb = PBHASHEGL.find(getCurrentDrawableEGL())) != NULL)
{
mapped = mapInvalidateAttachments(pb, numAttachments, attachments);
if(mapped) attachments = mapped;
framebuffer = pb->getFBO();
}
}
_glInvalidateNamedFramebufferData(framebuffer, numAttachments, attachments);
delete [] mapped;
}


void invalidateNamedFramebufferSubData(GLuint framebuffer,
GLsizei numAttachments, const GLenum *attachments, GLint x, GLint y,
GLsizei width, GLsizei height)
{
GLenum *mapped = NULL;

if(fconfig.egl)
{
FakePbuffer *pb;
if(framebuffer == 0
&& (pb = PBHASHEGL.find(getCurrentDrawableEGL())) != NULL)
{
mapped = mapInvalidateAttachments(pb, numAttachments, attachments);
if(mapped) attachments = mapped;
framebuffer = pb->getFBO();
}
}
_glInvalidateNamedFramebufferSubData(framebuffer, numAttachments, attachments,
x, y, width, height);
delete [] mapped;
}


Bool isDirect(GLXContext ctx)
{
if(fconfig.egl)
Expand Down
33 changes: 33 additions & 0 deletions server/backend.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Copyright (C)2019-2021 D. R. Commander
// Copyright (C)2026 Tahmid Zaman
//
// This library is free software and may be redistributed and/or modified under
// the terms of the wxWindows Library License, Version 3.1 or (at your option)
Expand Down Expand Up @@ -34,6 +35,25 @@ namespace backend
{
void bindFramebuffer(GLenum target, GLuint framebuffer, bool ext = false);

void blitNamedFramebuffer(GLuint readFramebuffer, GLuint drawFramebuffer,
GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, GLint dstX0,
GLint dstY0, GLint dstX1, GLint dstY1, GLbitfield mask, GLenum filter);

GLenum checkNamedFramebufferStatus(GLuint framebuffer, GLenum target,
bool ext = false);

void clearNamedFramebufferfi(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, GLfloat depth, GLint stencil);

void clearNamedFramebufferfv(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, const GLfloat *value);

void clearNamedFramebufferiv(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, const GLint *value);

void clearNamedFramebufferuiv(GLuint framebuffer, GLenum buffer,
GLint drawbuffer, const GLuint *value);

GLXContext createContext(Display *dpy, VGLFBConfig config, GLXContext share,
Bool direct, const int *glxAttribs);

Expand Down Expand Up @@ -66,11 +86,24 @@ namespace backend

void getFramebufferParameteriv(GLenum target, GLenum pname, GLint *params);

void getFramebufferParameterivEXT(GLuint framebuffer, GLenum pname,
GLint *params);

void getIntegerv(GLenum pname, GLint *params);

void getNamedFramebufferAttachmentParameteriv(GLuint framebuffer,
GLenum attachment, GLenum pname, GLint *params, bool ext = false);

void getNamedFramebufferParameteriv(GLuint framebuffer, GLenum pname,
GLint *param);

void invalidateNamedFramebufferData(GLuint framebuffer,
GLsizei numAttachments, const GLenum *attachments);

void invalidateNamedFramebufferSubData(GLuint framebuffer,
GLsizei numAttachments, const GLenum *attachments, GLint x, GLint y,
GLsizei width, GLsizei height);

Bool isDirect(GLXContext ctx);

Bool makeCurrent(Display *dpy, GLXDrawable draw, GLXDrawable read,
Expand Down
Loading