[WIP]fix: solve ciclePacking valueField field not work#4015
Open
LonelySnowman wants to merge 2 commits intoVisActor:developfrom
Open
[WIP]fix: solve ciclePacking valueField field not work#4015LonelySnowman wants to merge 2 commits intoVisActor:developfrom
LonelySnowman wants to merge 2 commits intoVisActor:developfrom
Conversation
Contributor
Author
|
@xuanhun 辛苦抽空帮忙 review 下这个 PR。 |
xuefei1313
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个分支是...
🔗 相关 issue 链接
修复：#3926
🔗 相关的 PR 链接
None
🐞 Bugserver 用例 id
None
💡 问题的背景&解决方案
circlePacking 中 valueField 字段不生效。
@visactor/vgrammar-hierarchy CirclePackingLayout 的 layout 方法仅解析 value 字段，不支持 field 映射，添加一个方法将 valueField 字段转化为 value 传入。
📝 Changelog
☑️ 自测
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough