test: add test getChartSpecWithContext with lineChart#254
Open
RubMaker wants to merge 1 commit intoVisActor:developfrom
Open
test: add test getChartSpecWithContext with lineChart#254RubMaker wants to merge 1 commit intoVisActor:developfrom
RubMaker wants to merge 1 commit intoVisActor:developfrom
Conversation
Contributor
|
Besides this test case, you can also add a test case of line chart with color field. |
xile611
reviewed
May 27, 2025
| } | ||
| ] | ||
| }; | ||
| const { chartType, spec } = getChartSpecWithContext(context); |
Contributor
There was a problem hiding this comment.
这个测试太简单了，起不到本质上的意义，不能覆盖各种大模型产出线图的场景
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#215
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
add unit test for getChartSpecWithContext() when chartType is linechart
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough