Fix issue 5088 carousel fractional row#5192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n\nRe-submit the fix from contributor PR #5190 on a fresh branch based on latest develop.\n\nThis fixes animated fractional row scrolling for TableCarouselAnimationPlugin, e.g. rowCount: 1.5, by preserving fractional row targets in animated scrollToRow calls and avoiding the integer snap-back correction for fractional rows.\n\n### Validation\n\n- pnpm --dir packages/vtable compile\n- pre-push rush test: passed with warnings