fix: prevent Gantt crash when zoomScale is configured without scales#5202
Open
Jian-Zhang08 wants to merge 1 commit into
Open
fix: prevent Gantt crash when zoomScale is configured without scales#5202Jian-Zhang08 wants to merge 1 commit into
Jian-Zhang08 wants to merge 1 commit into
Conversation
_sortScales accessed timelineHeader.scales.length without checking that scales was defined. When only zoomScale is configured (and the zoom scale manager has not populated scales yet), timelineHeader.scales is undefined, so opening the Gantt threw. Guard the access with timelineHeader?.scales. Closes VisActor#5159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
Fixes #5159
💡 Background and solution
Opening Gantt with only
zoomScale(noscales) threw:_sortScales()accessedtimelineHeader.scales.lengthwithout a guard, andscalesisundefineduntil the zoom scale manager populates it. Guarded withtimelineHeader?.scales.📝 Changelog
_sortScalesagainst undefinedscalesinGantt.ts.☑️ Self-Check before Merge