fix(vtable): map sorted view index to source record in deleteRecords/updateRecords - #5330
Open
william-xue wants to merge 1 commit into
Open
william-xue wants to merge 1 commit into
william-xue wants to merge 1 commit into
Conversation
…updateRecords deleteRecords/updateRecords receive body display indices, but the sync branches of DataSource used them directly as indices into this.records (_source, source order). Sorting keeps _source in source order and stores the view -> source mapping in currentIndexedData, so on a sorted table the wrong record was deleted/updated in the user's records array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
No tracking issue. Found while checking
syncRecordOperationsToSourceRecordson a sorted table.💡 Background and solution
syncRecordOperationsToSourceRecords: truepromises thatdeleteRecords/updateRecordswrite back to the array passed inoptions.records. Both APIs receive body display indices, and the sync branches inDataSourceused that display index directly as an index intothis.records:this.recordsis_source, i.e. the data source array in source order. Sorting does not reorder_source:DataSource.sort()only stores the view → source mapping incurrentIndexedData, which is exactly what the non-sync paths already use (deleteRecordsForSorted/updateRecordsForSortedboth readthis.currentIndexedData[recordIndex]). Filtering keeps the same contract, because the view index then maps identically onto the filtered_source.So on a sorted table the sync path touched the wrong record. Reproduced with the published 1.26.8 UMD bundle (desc-sorted
id, 5 records, headless Chrome):[5,4,3,2,1])deleteRecords([0])[2,3,4,5], view[5,4,3,2]— id 5 still visible, id 1 silently dropped[1,2,3,4], view[4,3,2,1]updateRecords([{id:5,name:'FIVE-UPDATED'}], [0])[0](id 1) replaced, view[5,5,4,3,2]— duplicate id 5[5,4,3,2,1]Fix: map the display index back to the data source index through
currentIndexedDatabefore readingthis.records(_getRecordIndexFromViewIndex, identity when the table is neither sorted nor filtered, so the existing behavior is unchanged). Tree / grouped data are untouched — those entries are arrays and keep the previous fallback.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough