Repository navigation
Upload one release archive per platform - #7
Merged
Merged
Conversation
Every platform prebuild is named bindings.node and release assets are flat, so uploading prebuilds/**/* raced three same-named uploads: overwrite_files deleted each other's asset (404 on v1.3.61) and earlier releases silently kept only one platform. Tar each platform dir into nlpplus-<tag>-<platform>.tar.gz and upload those instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub release step of run 38599499844 failed with `Not Found - update-a-release-asset`.
Cause: each platform prebuild is a file named `bindings.node`, and release assets have no folders. `files: prebuilds/**/*` uploaded three files with the same name at the same time, and `overwrite_files` let each upload delete another's asset. Earlier releases (v1.3.59, v1.3.60) didn't fail, but each kept only one platform's `bindings.node`.
Fix: pack each `prebuilds//` into `nlpplus--.tar.gz` and upload only those archives.
Not affected: npm installs. The prebuilds ship inside the npm package, and `scripts/install.js` never downloads from releases. `nlpplus@1.3.61` published normally.
v1.3.61 release: repaired by hand with the three archives, built from that run's saved build files.
Testing: the packing was tested by hand on v1.3.61's files. The workflow step itself first runs on the next release.
🤖 Generated with Claude Code