Repository navigation
Retry artifact uploads and report failed tag releases - #39
Merged
Merged
Conversation
v2.2.39 (engine v4.2.0) never reached PyPI: the Linux wheel job built every wheel, then GitHub rejected the artifact finalize with a 403, so upload_pypi and the release were skipped. Nothing reported it, and the successful "Update nlp-engine & publish" run made it look shipped. - Retry each upload-artifact step once (overwrite: true). - On a v* tag, if any job fails, open an issue linking the run. Refs #38, VisualText/nlp-engine#744 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
NLPPlus v2.2.39 (engine v4.2.0) never reached PyPI. The Linux wheel job built every wheel, then GitHub returned
Failed to FinalizeArtifact ... (403) Forbidden. Becauseupload_pypiand Make release need every build job, both were skipped. Nothing reported the failure for five days. The Update nlp-engine & publish run had succeeded, so the release looked shipped. v2.2.37 hit the same kind of failure once before.What
upload-artifactstep now runs withcontinue-on-error. If it fails, a second attempt runs withoverwrite: true. A failed retry still fails the job.notify_failurejob runs onv*tags when any job fails. It opens an issue in this repo naming the tag and linking the run, with a pointer to Re-run failed jobs.PR and
workflow_dispatchruns are unaffected: the notice job only runs on tags.The v2.2.39 run itself (35643462731) is being re-run separately. This PR prevents the next silent failure.
Refs #38, VisualText/nlp-engine#744
🤖 Generated with Claude Code