Skip to content

(RND-15784) feat: add Shipper/Consignee #548

Merged
Ayden666 merged 6 commits intomasterfrom
rnd-15784
Sep 24, 2025
Merged

(RND-15784) feat: add Shipper/Consignee #548
Ayden666 merged 6 commits intomasterfrom
rnd-15784

Conversation

@Ayden666
Copy link
Contributor

@Ayden666 Ayden666 commented Aug 12, 2025

RELATED TICKETS

! Do not post related PRs here, unless they are open source !

CHANGELOG

  • describe code changes

TESTS

  • describe your test strategy

COMMENTS

  • any other business

@Ayden666
Copy link
Contributor Author

Unit test for filtering by shipper and consignee is failing right now because the trades fields are empty. This is probably because whichever API key we're using to run the test doesn't have the feature flag for Shipper/Consignee. I'll just leave it for now since we aren't gonna merge this PR until Shipper/Consignee is generally available anyways.

hooks:
- id: black
language_version: python3.9.0
language_version: python3.9.19
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this because I'm using an Apple ARM chip and cannot install Python 3.9.0. Not sure what's the best approach here since many other docs & requirements all list Python 3.9.0 🤔

The set up is almost identical as above except one command; to create a virtual environment for Python 3.8 you should run:

```bash
python -m venv venv
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is the same as the one above so I'm not sure why this is here lol

@Ayden666 Ayden666 merged commit 055dfad into master Sep 24, 2025
11 of 12 checks passed
@Ayden666 Ayden666 deleted the rnd-15784 branch September 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants