Conversation
FenderStrat85
approved these changes
Sep 24, 2025
FenderStrat85
left a comment
FenderStrat85
left a comment
There was a problem hiding this comment.
LGTM - however I don't have very little knowledge of this PR, so I wouldn't take this as a green light to merge.
Contributor
Author
This is a really simple change so I'll merge. The endpoint already exists in Cargo API and all I'm doing is passing an existing param to the endpoint. I'm firefighting anyways so if there's any issue I'll be on it 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELATED TICKETS
! Do not post related PRs here, unless they are open source !
CHANGELOG
quantity_at_time_ofparam toCargoTimeSeries.search()functionTESTS