Repository navigation
Name the priority levels Express, Priority and Best-effort - #612
Merged
Merged
Conversation
The priority docstrings described the three levels as "highest", "medium" and "lowest" priority. Use the product names and pickup promises instead: PRIO1 is Express (picked up within 10 seconds, p99), PRIO2 is Priority (within 1 minute, p99) and PRIO3 is Best-effort (within 10 minutes, p99). The enum values stay PRIO1, PRIO2 and PRIO3; only the docstrings, the field description and the PriorityTooHighError CLI message change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GJhF9p9qA66AE7stT2YCrz
jmtts
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client's docstrings described the three priority levels as "highest", "medium" and "lowest" priority, which is not how the levels are named anywhere else. The decision is one name per level, used everywhere: PRIO1 is Express (picked up within 10 seconds, p99), PRIO2 is Priority (within 1 minute, p99) and PRIO3 is Best-effort (within 10 minutes, p99). The names are product names and are not translated. This pull request brings the client's documentation in line. Nothing a program reads changes: the enum values stay
PRIO1,PRIO2andPRIO3, and validation, error codes and the request field are untouched.What changed
werk24/models/v2/enums.py,Priority:werk24/techread.py(thepriorityargument ofread_drawing,read_drawing_with_hooksandread_drawing_with_callback) andwerk24/utils/priority.py:Valid values are "PRIO1", "PRIO2", "PRIO3" (case-insensitive).->Valid values are "PRIO1" (Express), "PRIO2" (Priority) and "PRIO3" (Best-effort), case-insensitive.werk24/models/v2/internal.py, thepriorityfield description: "Valid values are PRIO1, PRIO2, PRIO3." -> "Valid values are PRIO1 (Express), PRIO2 (Priority) and PRIO3 (Best-effort)."werk24/utils/exceptions.py,PriorityTooHighError:Left alone on purpose: two "best effort" docstrings, in
werk24/cli/commands/techread.py(showing an image) andwerk24/techread.py(reading an error response body), which describe how a helper behaves and not a priority level.Tests
.venv/bin/python -m pyteston Python 3.13, as CLAUDE.md gives it: 1023 passed, 5 skipped before the change and 1023 passed, 5 skipped after. No test pins these docstrings or the CLI message wording. The five skips are the credential-gated live tests.Questions for the owner
None. This only renames levels in documentation and in one CLI hint; no value, behaviour or default changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GJhF9p9qA66AE7stT2YCrz