Skip to content

Remove the CANVAS_TABLES ask - #613

Merged
jmtts merged 1 commit into
mainfrom
claude/remove-canvas-tables-ask
Oct 13, 2026
Merged

jmtts merged 1 commit into
mainfrom
claude/remove-canvas-tables-ask

Conversation

@werk24

@werk24 werk24 commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

The API never returned a result for the CANVAS_TABLES ask, so offering it in the client only let a caller ask for something that would not arrive. This removes it from the v1 models.

What changed

  • werk24/models/v1/ask.py: W24AskType.CANVAS_TABLES, W24AskCanvasTables, its entry in W24AskUnion and its entry in the deserialize_ask_v1 lookup are gone, together with the now unused W24FileFormatTable import. W24FileFormatTable itself stays in werk24/models/v1/file_format.py, unchanged.
  • tests/test_canvas_tables_ask_removed.py: pins that the member and the class are gone, that an ask list naming CANVAS_TABLES is refused by both AskUnion and W24AskUnion with a ValidationError, that deserialize_ask_v1 raises Unknown Ask Type for it, and that the asks around it still resolve.

What a caller notices

  • Code that builds W24AskCanvasTables() or names W24AskType.CANVAS_TABLES fails at import or on the attribute after upgrading. Since the ask never produced a result, removing it from the ask list is the whole fix.
  • A raw ask list such as [{"ask_type": "NOTES"}, {"ask_type": "CANVAS_TABLES"}] is now refused when it is validated, before anything is sent, instead of being sent and left without an answer.
  • No other ask, response model or enum changes. No version bump here; versions are bumped in their own commits.

Tests

Python 3.13.16, set up as CLAUDE.md describes:

uv venv .venv --python 3.13
uv pip install -r requirements.txt -r tests/requirements.txt -e .
.venv/bin/python -m pytest

Result: 1025 passed, 5 skipped (the credential-gated live tests).

Questions for the owner

One question. It does not block the merge on its own, but the merge has to wait for the API side.

  1. Merge only after the API has stopped accepting this ask?
    • The API still accepts CANVAS_TABLES today. Merging this first would make the client refuse an ask the API has not yet retired, out of step with it.
    • Once the API no longer accepts the ask, this merge changes nothing for a caller except that the dead option is gone.
    • Recommendation: yes, merge after the API change is released.

Not questions, for after the deploy:

  • Bump the version in its own commit when the next release is cut, and mention the removal in the release notes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01H1h5ef3RZE5r2di6pyYceu


Generated by Claude Code

The API never returned a result for the CANVAS_TABLES ask, so offering it
in the client only let a caller ask for something that would not arrive.
Remove W24AskType.CANVAS_TABLES, W24AskCanvasTables and their entries in
W24AskUnion and the v1 deserializer.

An ask list that still names CANVAS_TABLES is now refused when it is
built: both unions raise a ValidationError and deserialize_ask_v1 raises
"Unknown Ask Type". W24FileFormatTable stays in file_format, unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H1h5ef3RZE5r2di6pyYceu
@jmtts
jmtts merged commit b8faa9c into main Oct 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants