Repository navigation
Remove the CANVAS_TABLES ask - #613
Merged
Merged
Conversation
The API never returned a result for the CANVAS_TABLES ask, so offering it in the client only let a caller ask for something that would not arrive. Remove W24AskType.CANVAS_TABLES, W24AskCanvasTables and their entries in W24AskUnion and the v1 deserializer. An ask list that still names CANVAS_TABLES is now refused when it is built: both unions raise a ValidationError and deserialize_ask_v1 raises "Unknown Ask Type". W24FileFormatTable stays in file_format, unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H1h5ef3RZE5r2di6pyYceu
jmtts
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API never returned a result for the
CANVAS_TABLESask, so offering it in the client only let a caller ask for something that would not arrive. This removes it from the v1 models.What changed
werk24/models/v1/ask.py:W24AskType.CANVAS_TABLES,W24AskCanvasTables, its entry inW24AskUnionand its entry in thedeserialize_ask_v1lookup are gone, together with the now unusedW24FileFormatTableimport.W24FileFormatTableitself stays inwerk24/models/v1/file_format.py, unchanged.tests/test_canvas_tables_ask_removed.py: pins that the member and the class are gone, that an ask list namingCANVAS_TABLESis refused by bothAskUnionandW24AskUnionwith aValidationError, thatdeserialize_ask_v1raisesUnknown Ask Typefor it, and that the asks around it still resolve.What a caller notices
W24AskCanvasTables()or namesW24AskType.CANVAS_TABLESfails at import or on the attribute after upgrading. Since the ask never produced a result, removing it from the ask list is the whole fix.[{"ask_type": "NOTES"}, {"ask_type": "CANVAS_TABLES"}]is now refused when it is validated, before anything is sent, instead of being sent and left without an answer.Tests
Python 3.13.16, set up as
CLAUDE.mddescribes:Result: 1025 passed, 5 skipped (the credential-gated live tests).
Questions for the owner
One question. It does not block the merge on its own, but the merge has to wait for the API side.
CANVAS_TABLEStoday. Merging this first would make the client refuse an ask the API has not yet retired, out of step with it.Not questions, for after the deploy:
🤖 Generated with Claude Code
https://claude.ai/code/session_01H1h5ef3RZE5r2di6pyYceu
Generated by Claude Code