feat(delivery): harden manager self-update and prepare SignPath migration#177
feat(delivery): harden manager self-update and prepare SignPath migration#177Wangnov wants to merge 26 commits into
Conversation
a138dbf to
4c1d083
Compare
# Conflicts: # .github/workflows/release.yml # docs/release.md # scripts/sync-mirror.sh
# Conflicts: # .github/workflows/release.yml # docs/release.md # scripts/check-release-reuse.mjs # scripts/check-release-version.mjs # scripts/mirror-release.test.mjs # scripts/release-workflow.test.mjs
# Conflicts: # .github/workflows/release.yml # scripts/mirror-release.mjs # scripts/mirror-release.test.mjs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86906cc534
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "::error::unexpected upstream workflow: $UPSTREAM_WORKFLOW_NAME" | ||
| exit 1 | ||
| } | ||
| [[ "$UPSTREAM_PATH" == ".github/workflows/release-source.yml" ]] || { |
There was a problem hiding this comment.
Strip the workflow_run @ref suffix
For the tag-signalled release path, GitHub populates workflow_run.path with the workflow file plus the ref suffix (for example .github/workflows/build.yml@main in the documented workflow-run object), so this equality against the bare filename rejects every completed Release source run before any credentialed release jobs start. Strip the @... suffix, or compare against the suffixed form, before failing preflight.
Useful? React with 👍 / 👎.
Summary
Validation
npm run check/npm run lint/npm run build— passnpm test— pass(27 files / 255 tests)npm run test:release— pass(73/73)cargo test --locked --manifest-path src-tauri/Cargo.toml --lib— pass(126/126)git diff --check— passcodex review --uncommitted— 未发现由当前改动引入的明确功能缺陷codex review --base codex/issue-170-mirror-monotonic-promotion— 未发现需修复的 P1/P2 正确性或回归问题86906ccExternal rollout gates
本 PR 保持 Draft,以下事项尚未完成:
releaseenvironment policy 重新录入 Apple/Tauri signing secrets,并完成旧 credential 清理。Refs #171