fix(ui): say on screen when anonymous mode is rewriting what is displayed - #52
Merged
Merged
Conversation
…ayed (#49) Anonymous mode replaces hostnames, addresses, user names and domains everywhere a log is displayed, and it persists across restarts. The only sign of it was a 16 px icon at the bottom of the sidebar tinted with the accent colour — and that button sits directly above the settings one, which is how it gets turned on without being meant. So it was reported as the application identifying sources wrongly since v1.4: a collector recording 10.211.8.13 was showing 192.0.2.1, and nothing anywhere said why. Two issues came out of one session in that state. The string for this already existed. "Anonymous mode is on" has been sitting in all eight locale files since the feature landed, rendered nowhere — the indicator was designed and then never wired up. Now a banner states it above the columns whose values are substituted, says that stored data and exports are unchanged, and carries the way back in the same place. A toast fires on the change itself, from either entry point, so a misclick announces itself at the moment it happens rather than three days later.
It said stored data AND exports were unchanged. Exports are about to stop being unchanged in anonymous mode — they follow the screen unless the real values are asked for — and a banner that outlives the sentence it makes is worse than a shorter one. Stored data is the part that stays true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
What was reported
The sources are not identified wrongly. Anonymous mode is on, and the screenshot shows exactly what that mode promises:
192.0.2.1(RFC 5737, reserved for documentation) where the collector recorded10.211.8.13, andhost-01,host-02,host-03for the hostnames. Version 1.3 predates the feature, which is why it looks like a regression introduced by 1.4.Why it reads as a bug
The mode rewrites every host, address, user name and domain on screen, persists across restarts, and its only sign was a 16 px ghost icon at the bottom of the sidebar, tinted with the accent colour. No words anywhere.
That button sits directly above the settings one, which is how it gets turned on without being meant — and once on, nothing brings it back to mind. Two issues came out of one session in that state: #49, and the "prefix" in #50, which was this mode rewriting a hostname the importer had left inside a message.
Digging for the right remedy turned up the real story:
anonymous.active— "Anonymous mode is on" — has been sitting in all eight locale files since the feature landed, rendered nowhere. The indicator was designed and never wired up.What this does
A banner, while the mode is on, above the columns whose values are substituted:
Not changed
The redaction itself. It replaces hosts, addresses, user names, domains, e-mails and MACs — it does not touch vendor-specific fields such as
devname=or a serial indevid=, which is visible in the reporter's own screenshot. Widening it by guessing would start renaming ordinary words in message text; the settings panel enumerates what the mode covers rather than promising more than it does.Verified
svelte-check --fail-on-warnings, the frontend build andgo test ./...are clean. Three strings added across all 8 locales (464 keys × 8, parity checked). The screenshots of anonymous mode on the site were regenerated from the real component — they had been showing the misleading state, which is the whole subject of this issue.