Skip to content

move NeuralAudio implementation to pdnam+; create new MicroNam called pdnam~#3

Merged
dromer merged 8 commits into
mainfrom
feature/pdnamplus
Apr 28, 2026
Merged

move NeuralAudio implementation to pdnam+; create new MicroNam called pdnam~#3
dromer merged 8 commits into
mainfrom
feature/pdnamplus

Conversation

@dromer
Copy link
Copy Markdown
Contributor

@dromer dromer commented Apr 27, 2026

  • adjust readme
  • sort out licensing
  • expand MicroNAM example

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits PDNAM into two Pure Data externals: a new pdnam~ based on MicroNAM, and a pdnam+~ external that retains the NeuralAudio-based implementation, along with build/packaging updates to ship both.

Changes:

  • Replaced the pdnam~ implementation with a MicroNAM-based JSON weight loader and updated its help patch accordingly.
  • Added a new pdnam+~ external containing the previous NeuralAudio-based loader and a corresponding help patch.
  • Updated build system, submodules, CI runner targets, and README/license notes to reflect the split.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pdnam~.cpp Switches pdnam~ to MicroNAM + JSON weight parsing and per-sample inference.
pdnam~-help.pd Updates the help patch to demonstrate the new MicroNAM-based pdnam~ usage.
pdnam+~.cpp Introduces pdnam+~ using NeuralAudio’s NeuralModel loader/processor.
pdnam+~-help.pd Adds help patch for the NeuralAudio-based pdnam+~.
data/BossWN-feather.nam Adds an additional example model for testing.
README.md Documents the new split (pdnam~ vs pdnam+~) and licensing notes.
Makefile Reworks build to produce a multi-class library and adds MicroNAM/json include paths.
.gitmodules Adds MicroNAM and nlohmann/json submodules.
.github/workflows/build.yml Updates Linux runner targets for CI.
Comments suppressed due to low confidence (2)

.github/workflows/build.yml:48

  • runs-on: ubuntu-22.04-arm is not a standard GitHub-hosted runner label (typically ubuntu-22.04-arm64 / ubuntu-24.04-arm64). Also actions/checkout@v6 is not a valid released version. Adjust the runner label and action versions so the arm64 job can start successfully.
    runs-on: ubuntu-22.04-arm
    steps:
    - uses: actions/checkout@v6
      with:
        submodules: recursive

.github/workflows/build.yml:18

  • The workflow references actions/checkout@v6, which is not a valid released major version (current major is v4). Update this (and other action references in the file, e.g. upload-artifact) to a valid version so CI doesn't fail before building.
    runs-on: ubuntu-22.04
    steps:
    - uses: actions/checkout@v6
      with:
        submodules: recursive

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pdnam~.cpp
Comment thread pdnam~.cpp
Comment thread README.md Outdated
@dromer dromer merged commit 4dcee52 into main Apr 28, 2026
4 checks passed
@dromer dromer deleted the feature/pdnamplus branch April 28, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants