move NeuralAudio implementation to pdnam+; create new MicroNam called pdnam~#3
Merged
Conversation
…ct, remove redundant load mode setters
There was a problem hiding this comment.
Pull request overview
This PR splits PDNAM into two Pure Data externals: a new pdnam~ based on MicroNAM, and a pdnam+~ external that retains the NeuralAudio-based implementation, along with build/packaging updates to ship both.
Changes:
- Replaced the
pdnam~implementation with a MicroNAM-based JSON weight loader and updated its help patch accordingly. - Added a new
pdnam+~external containing the previous NeuralAudio-based loader and a corresponding help patch. - Updated build system, submodules, CI runner targets, and README/license notes to reflect the split.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pdnam~.cpp |
Switches pdnam~ to MicroNAM + JSON weight parsing and per-sample inference. |
pdnam~-help.pd |
Updates the help patch to demonstrate the new MicroNAM-based pdnam~ usage. |
pdnam+~.cpp |
Introduces pdnam+~ using NeuralAudio’s NeuralModel loader/processor. |
pdnam+~-help.pd |
Adds help patch for the NeuralAudio-based pdnam+~. |
data/BossWN-feather.nam |
Adds an additional example model for testing. |
README.md |
Documents the new split (pdnam~ vs pdnam+~) and licensing notes. |
Makefile |
Reworks build to produce a multi-class library and adds MicroNAM/json include paths. |
.gitmodules |
Adds MicroNAM and nlohmann/json submodules. |
.github/workflows/build.yml |
Updates Linux runner targets for CI. |
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:48
runs-on: ubuntu-22.04-armis not a standard GitHub-hosted runner label (typicallyubuntu-22.04-arm64/ubuntu-24.04-arm64). Alsoactions/checkout@v6is not a valid released version. Adjust the runner label and action versions so the arm64 job can start successfully.
runs-on: ubuntu-22.04-arm
steps:
- uses: actions/checkout@v6
with:
submodules: recursive
.github/workflows/build.yml:18
- The workflow references
actions/checkout@v6, which is not a valid released major version (current major is v4). Update this (and other action references in the file, e.g. upload-artifact) to a valid version so CI doesn't fail before building.
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v6
with:
submodules: recursive
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.