refactor: replace _build_recursive with orchestrator#323
Draft
Blackgaurd wants to merge 1 commit into04-17-feat_add_build_orchestratorfrom
Draft
refactor: replace _build_recursive with orchestrator#323Blackgaurd wants to merge 1 commit into04-17-feat_add_build_orchestratorfrom
Blackgaurd wants to merge 1 commit into04-17-feat_add_build_orchestratorfrom
Conversation
This was referenced Apr 17, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 17, 2026
0a97d64 to
6fb344e
Compare
6fdc1a6 to
4a73650
Compare
4a73650 to
4aebc80
Compare
6fb344e to
461b6ea
Compare
461b6ea to
3820536
Compare
4aebc80 to
06c0672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Wires
run_build()intobuild_dataset()and deletes_build_recursive(). This is the switchover PR.What changed
build_dataset()now delegates torun_build()(orchestrator) instead of_build_recursive()_build_recursive()(~120 lines)NoValidTimestampsErrorandgenerate_timestampsto newservice/timestamps.pyto break circular import (builder -> orchestrator -> worker -> builder)builder.pyre-exports both for backward compatibility (api/routes.py, tests)test_builder.py: replaced 16 tests that tested_build_recursiveinternals with 3 delegation tests (behavior now covered by test_scheduler + test_worker + test_orchestrator)test_concurrent_builds.py: mock targets changed fromservice.builder.*toservice.scheduler.registry+service.worker.*Why
_build_recursivemixed scheduling (dependency resolution, start-date clamping, lookback expansion) with execution (timestamp check, builder subprocess, DB insert). The new architecture separates these concerns into scheduler, worker, and orchestrator.Benefit
🤖 Generated with Claude Code