Conversation
This will allow us to separate the slowdown from using the shared heap from the slowdown due to all the other transformations we have to apply.
tlively
requested review from
stevenfontanella
and removed request for
a team
September 25, 2026 21:06
| funcTable.shared = shared; | ||
| externTable.wasm = wasm; | ||
| wasm->features.setSharedEverything(); | ||
| externTable.shared = shared; |
Member
There was a problem hiding this comment.
I'm curious, were funcTable and externTable not shared before this PR? Looks like no?
Member
Author
There was a problem hiding this comment.
Oh, I should remove this. We support shared tables in our IR, but it doesn't do anything and the output binary is the same.
stevenfontanella
approved these changes
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to separate the slowdown from using the shared heap from the slowdown due to all the other transformations we have to apply.