Repository navigation
Conversation
When `DAE2` removes unused values, replacing an expression (such as a `drop` of a concrete block containing an `unreachable` child) with its kept children can change the expression's type from `none` to `unreachable`. Track when a replacement in `Optimizer` becomes `unreachable` and run `ReFinalize` in parallel on affected functions at the end of `DAE2::optimize()` after global type rewriting.
There was a problem hiding this comment.
Code Review
This pull request introduces a refinalization step in the Dead Argument Elimination (DAE2) pass to handle cases where removing unused expression results introduces new unreachability, requiring enclosing expressions to be refinalized. It adds a refinalize flag to FunctionInfo and runs a custom Refinalizer pass after global type rewriting to ensure correct type propagation for instructions like call_ref and ref.func. Test cases have been added to verify this behavior. There are no review comments, so I have no additional feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
DAE2removes unused values, replacing an expression (such as adropof a concrete block containing anunreachablechild) with its kept children can change the expression's type fromnonetounreachable. Track when a replacement inOptimizerbecomesunreachableand runReFinalizein parallel on affected functions at the end ofDAE2::optimize()after global type rewriting.