Repository navigation
[Unsubtyping] Handle table.grow - #9327
Merged
Merged
Conversation
SubtypingDiscoverer did not previously note the constraint that TableGrow's `value` operand had to be a subtype of the table's element type. This would cause Unsubtyping to incorrectly remove that subtyping, leading to validation failures. This is included in #9263, but split it out to make the fuzzer happy.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SubtypingDiscoverer in src/ir/subtype-exprs.h to correctly track subtype relationships during table.grow operations by noting the subtype relation between the value being added and the table's declared type. Additionally, a test case has been added to test/lit/passes/unsubtyping.wast to verify this behavior. There are no review comments to evaluate, and the changes look correct and well-tested.
kripken
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubtypingDiscoverer did not previously note the constraint that TableGrow's
valueoperand had to be a subtype of the table's element type. This would cause Unsubtyping to incorrectly remove that subtyping, leading to validation failures.This is included in #9263, but split it out to make the fuzzer happy.