Skip to content

Do not support JS strings beyond 2^32 bytes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daxpedda wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Do not support JS strings beyond 2^32 bytes #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion proposals/js-text-encoding-builtins/Overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func encodeStringIntoUTF8Memory(
string: externref,
start: i64,
end: i64
) -> (i64, i64)
) -> (i32, i64)
{
start >>>= 0;
end >>>= 0;
Expand Down Expand Up @@ -217,3 +217,7 @@ There is an [ongoing discussion](https://github.com/WebAssembly/esm-integration/
### Why do the provided functions take `i64` instead of `i32`?

This enables support for the Memory64 proposal.

### What about JS strings larger than 2^32 bytes?

Given that currently no engine supports strings larger than 2^30 and there are currently no plans to do so, we concluded to postpone specifically addressing this. See [#3](https://github.com/WebAssembly/js-text-encoding-builtins/issues/3).