-
Notifications
You must be signed in to change notification settings - Fork 103
feat: add OpenSearch distance operations and selectors #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmiguerodriguez
wants to merge
33
commits into
master
Choose a base branch
from
feature/os-distance-operations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
14c53c2
feat: add OpenSearch distance operations and selectors
mmiguerodriguez df6ffe6
Merge branch 'master' into feature/os-distance-operations
mmiguerodriguez a356951
feature: added new integration test
mmiguerodriguez 9da8da8
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez 54f1eac
remove invalid assertions
mmiguerodriguez 23b7b20
fix tests
mmiguerodriguez b529331
more test fixes...
mmiguerodriguez b461a0f
fix test by using default constructor
mmiguerodriguez bec8eb7
Merge branch 'master' into feature/os-distance-operations
mmiguerodriguez 41fae1f
tests: add PR recommendations
mmiguerodriguez ae37f6a
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez 44452ff
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez f47e055
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez dfe913b
refactor: use if/else chain with warn log for unsupported ops
mmiguerodriguez 5b7e4cd
fix: handle empty expectedTerms to prevent division by zero
mmiguerodriguez 152a361
docs: clarify OpenSearch regex vs Java regex syntax differences
mmiguerodriguez b82ab2d
refactor: move generic string helpers to DistanceHelper
mmiguerodriguez 7b612ad
fix: return 404 when no data found in age endpoints
mmiguerodriguez e17daa6
fix: return 404 in students endpoints and add 404 assertions in tests
mmiguerodriguez a874b55
fix: return 404 in queries endpoints and add 404 assertions
mmiguerodriguez 51ab79a
refactor: move queries module to new folder structure
mmiguerodriguez 4bf9147
style: remove redundant javadoc comments
mmiguerodriguez 9d6a2b0
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez f42b67e
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez fa3216a
fix: add env vars and comment out tests with errors
mmiguerodriguez 4541ab7
fix handle on wrong entity. wip OpenSearchIndexSchema
mmiguerodriguez a76e8e4
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez 173886e
fix: add index schema to ExecutionTracer
mmiguerodriguez b25da6d
Merge branch 'master' into feature/os-distance-operations
mmiguerodriguez 4984d0f
fix: remove unused pom.xml configuration
mmiguerodriguez 94dde39
Merge remote-tracking branch 'origin/master' into feature/os-distance…
mmiguerodriguez d6e76b8
Merge branch 'master' into feature/os-distance-operations
arcuri82 e77f17a
Merge branch 'master' into feature/os-distance-operations
arcuri82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for any map, explicitely state here in the comments what the
keys are, and what thevalues areThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this, since the indexSchema represents the schema of an OpenSearchIndex, we aren't in control of the keys for this schema.
Still I'll be reviewing if there's a better way to map this attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmiguerodriguez , maybe it is a misunderstanding, but I just meant to add docuemtnation, eg, something like:
in other parts of the code, we have comments like:
recall what written in for_developers.md