Fixes how empty XHTML and SVG elements are serialized#305
Fixes how empty XHTML and SVG elements are serialized#305PolariTOON wants to merge 3 commits intoWebReflection:mainfrom
Conversation
XHTML is case-sensitive so this matches only lowercase tags.
For consistency with XMLSerializer, only void XHTML elements should have a space. Ideally such change should also be applied on other XML documents, but trying here to keep things simple.
PolariTOON
force-pushed
the
xhtml-and-svg-void-elements
branch
from
979886d to
8ab487b
Compare
|
What issue is this trying to solve? |
|
Issues happen if you feed the HTML parser (of a browser) with XHTML content generated by LinkeDOM, resulting in the wrong DOM, because the HTML parser treats self-closing tags of non void elements as opening tags. People should likely not do that, but realistically that can happen if, for example:
This PR prevents LinkedDOM to generate such not roundtripping code when serializing an XHTML document. I can add the examples above as testcases if you want. |
| docType: '<?xml version="1.0" encoding="utf-8"?>', | ||
| ignoreCase: false, | ||
| voidElements | ||
| voidElements: /^(?:area|base|br|col|embed|hr|img|input|keygen|link|menuitem|meta|param|source|track|wbr)$/ |
There was a problem hiding this comment.
it misses a i I suppose but I don't understand why this is needed
| if (isOpened) { | ||
| if ('ownerSVGElement' in start) | ||
| out.push(' />'); | ||
| out.push('/>'); |
There was a problem hiding this comment.
this is a breaking change for people generating JSX-like output for files to serve + it might play badly with non-quoted attributes as in <el test=123/> ... this is a bad idea and it doesn't solve any issue?
2 participants
The DOM Parsing and Serialization spec defines that only some empty elements should be autoclosed when serializing XHTML: https://w3c.github.io/DOM-Parsing/#ref-for-dfn-html-namespace-3 . This PR aligns with this spec.
It also tells that among empty elements, only those ones get a space before the slash (
<link />instead of<link/>). As such, SVG elements should not have a space for example (<rect/>instead of<rect />). This implements such change. Ideally it should also be applied on other XML documents, but i wanted to keep things simple and not too invasive for the codebase.