Repository navigation
TIGER-335 batch 1: _isAdmin()→_isAllowed() in identity/matomo/schedule/backup/ally - #350
Merged
Merged
Conversation
…ule/backup/ally (v1.32.0)
Replace the deprecated resource-level _isAdmin() guards with privilege-scoped _isAllowed('<method>')
in five admin-only modules. Each service is granted to `admin` at the resource (wildcard privilege),
so the conversion is behavior-preserving; the in-method guard remains as defense-in-depth for any
in-process caller, now without a role comparer. No acl.ini changes needed (blanket admin covers all
method privileges). Tests green: 117 across the five modules.
Closes TIGER-349, TIGER-350, TIGER-351, TIGER-355, TIGER-356.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of the TIGER-335 per-module migration off the deprecated role comparers.
Five admin-only modules (each service granted to
adminat the resource, so the dispatcher already gates every method to admin): the resource-level_isAdmin()in-method guards are converted to privilege-scoped_isAllowed('<method>').savesavejobs,setSchedule,runNowrun,remove,restore,saveSettingsscan,scanModule,pages,scanAllBehavior-preserving (a wildcard-privilege admin grant covers each named privilege); the guard stays as defense-in-depth for any in-process caller, now without a role comparer. No
acl.inichanges needed. Tests green: 117 across the five modules.The deprecated comparers are deleted in the final release (TIGER-358) once every module is migrated.
🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ