Repository navigation
TIGER-335 batch 2: _isAdmin()→_isAllowed() in analytics/code/translations/profile/access - #351
Merged
Merged
Conversation
…ations/profile/access (v1.33.0) Mechanical, behavior-preserving conversion off the deprecated resource-level comparer in five more blanket-granted modules (incl. the with-privilege datatable can_edit/can_delete flags in code + access, which were already the correct shape — rename only). No acl.ini changes. Tests green: 206. Closes TIGER-339, TIGER-340, TIGER-345, TIGER-346, TIGER-354. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 2 of the TIGER-335 per-module migration. Mechanical, behavior-preserving conversion off the deprecated resource-level
_isAdmin()in five more blanket-granted modules:can_edit/can_deleteprivilege flags (already the correct shape — rename only)Org*servicesEach service is a wildcard-privilege grant to its role, so
_isAllowed('<method>')is behavior-identical; noacl.inichanges. Tests green: 206.🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ