Repository navigation
TIGER-335 batch 3: _isAdmin()→_isAllowed() in system + agent - #352
Merged
Merged
Conversation
Mechanical, behavior-preserving conversion off the deprecated comparer across the two largest admin
modules: system (8 services, 37 sites incl. the Sites datatable flag) and agent (17 sites + the
RESOURCE_CHAT capability check → _isAllowed('send', Tiger_Agent::RESOURCE_CHAT)). All services are
wildcard-privilege grants; no acl.ini changes. Tests green: 327.
Closes TIGER-336, TIGER-338.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 3 of the TIGER-335 migration — the two largest admin modules. Mechanical, behavior-preserving conversion off the deprecated resource-level
_isAdmin():can_deleteflag_isAllowed('send', Tiger_Agent::RESOURCE_CHAT)All services are wildcard-privilege grants to their role; no
acl.inichanges. Tests green: 327.🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ