Repository navigation
TIGER-335 batch 4: _isAdmin()→_isAllowed() in sms/seo/mcp/register/media/blog/cms - #353
Merged
Merged
Conversation
…media/blog/cms (v1.35.0)
Seven modules whose admin services are wildcard-privilege grants → behavior-preserving mechanical
conversion (register also had the _isAdmin('Register_AdminController') cross-resource form). Audited
each module's guest grant: all sit on genuinely-public CONTROLLERS (webhooks, sitemap, verify, index),
not the admin services with the in-method checks — so no F5 hole, no acl.ini change. Tests green: 515.
Closes TIGER-337, TIGER-341, TIGER-342, TIGER-347, TIGER-348, TIGER-352, TIGER-353.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 4 — seven modules whose admin services are wildcard-privilege grants, so the conversion is mechanical + behavior-preserving.
_isAdmin('Register_AdminController')cross-resource form), media (TIGER-341), blog (TIGER-342), cms (TIGER-337)Audit (part of TIGER-357): each of these modules grants
guest, but on genuinely-public controllers (sms inbound webhook, seo sitemap/robots/llms, mcp server, register verify, blog/cms index) — not on the admin services that carry the in-method checks. So there's no F5 hole here and noacl.inichange was needed. Tests green: 515.🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ