Repository navigation
TIGER-382: CI guard — forbid a plaintext literal through Tiger_Secret::resolve() - #362
Merged
Merged
Conversation
…::resolve() Tiger_Secret::resolve() returns an unrecognized value unchanged as plaintext (the adoption-friendly passthrough). This token-based unit guard makes the convention airtight: a STRING-LITERAL argument to resolve() must be a recognized scheme ref (ssm:/env:/file:/enc:/...), never a bare plaintext secret. Variables and concatenations (the runtime-config path) are not flagged. Scans library/core/modules (never tests/, which exercises the passthrough). Mutation-tested: the detector must catch a plaintext literal and pass a scheme ref, a variable, a concatenation and a comment. Rides the existing unit PHPUnit job; no workflow change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiger_Secret::resolve()returns an unrecognized value unchanged as plaintext (the adoption-friendly passthrough). This token-based PHPUnit guard makes the convention airtight.Rule: a string-literal argument to
Tiger_Secret::resolve()must be a recognized scheme ref (ssm:/env:/file:/enc:/…), never a bare plaintext secret. A variable or concatenation (the runtime-config path, e.g. the node'sresolve($base . 'ses_key_id')) is not flagged.library/,core/,modules/— nevertests/(which exercises the passthrough).unitjob, no workflow change.🤖 Generated with Claude Code
https://claude.ai/code/session_01ASauLLscjqdsNqBNsx2Typ