drs changes inshallah#27
Open
MOABDeveloper wants to merge 1 commit into
Open
Conversation
yamaan93
requested changes
Jun 11, 2026
Member
There was a problem hiding this comment.
I don't think there should be any changes here, you may have done something you shouldn't have by accident.
Member
There was a problem hiding this comment.
Don't send CAN stuff raw like this. I already have a CAN abstraction that you should be using. If you send me the servo data sheet I can work it in in a way that makes sense.
Member
There was a problem hiding this comment.
You need to add the steering wheel message to the CAN_Rx list at the bottom of the file too so that it actually get's processed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yamaan93 ples check and fix or merge