test: cover scan runner, normalize, and directory sync#65
Merged
Conversation
Adds unit tests for the remaining sensitive modules listed in #52: - scan/normalize: type normalization, breach-date parsing, sleep. - scan/runner: severityFor mapping (exported for testability) and runScan persistence, dedup, and provider-error isolation. - directory/sync: not-found, provider-error -> ERROR status, and the success path (upsert per user, ACTIVE status, synced count). With crypto (#56) and scim-auth (#57) already covered, this completes the test targets. Closes #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds unit tests for the remaining sensitive modules from #52.
Coverage added
normalizeType,parseBreachDate(missing/invalid/valid),sleep.severityFormapping (CRITICAL / HIGH / MEDIUM), now exported for testability;runScanfor new-finding persistence, dedup against existing breach records, and provider-error isolation.ERRORstatus + rethrow, and the success path (upsert per user,ACTIVEstatus, synced count).Combined with crypto (#56) and scim-auth (#57), the test targets in the issue are complete.
Closes #52
🤖 Generated with Claude Code