fix: stop reports grid update loop, add turbopack dev script#73
Merged
Conversation
RGL fires onLayoutChange on every layout-prop change (recreated each render), and it always called setLayout, feeding an endless setLayout -> render -> onLayoutChange cycle (Maximum update depth). Skip the update when no tile actually moved or resized.
dev:turbo runs next dev --turbopack for faster cold compiles; plain dev stays on webpack as the safe default (react-grid-layout uses require).
contentRect.width is fractional and jitters sub-pixel as tiles auto-fit; since containerW is a fitHeights effect dependency, the raw value changed every render and never settled. Round and dedupe it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maximum update depth exceededin ReportCanvas: RGLonLayoutChangefired on every layout-prop change and always called setLayout, creating an endless render loop. Now skips the update when no tile moved or resized.dev:turboscript (next dev --turbopack) for faster cold compiles; plaindevstays on webpack as the safe default.Test
🤖 Generated with Claude Code