Created a Climb command group#49
Open
dsakai4 wants to merge 3 commits into
Open
Conversation
dsakai4
force-pushed
the
Issue-46-Climb-Command-Group
branch
from
fddd753 to
8a01024
Compare
Ferris-Bueller7
approved these changes
Jan 26, 2025
Member
|
The OpenFunnel command needs to have its isFinished method rewritten instead of just returning false. In a sequential command group commands won't move on to the next one until the prior command finishes. So in the case of the one you wrote, OpenFunnel will never be finished so Climb will never start. |
dsakai4
force-pushed
the
Issue-46-Climb-Command-Group
branch
from
8a01024 to
5d04dac
Compare
jasonsoohoo
requested changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Climb command and a Climb command group that calls the Funnel Open command and the Climb command sequentially. Additionally edited javadocs for Funnel commands.