[Fix] Say why the downloads badge counts the v0.1.1 draft - #449
Merged
Conversation
#447 selects stable tags by the absence of a `-` in the tag rather than by GitHub's `prerelease` flag, and justified it by saying the flag is set on v0.1.1 by mistake. It is not. That tag is titled "v0.1.1 draft", its body calls it experimental, and it was never published as a release: this project has shipped four, v0.1.0, v0.1.2, v1.0.0 and v1.0.1. The real reason is the stronger one. All three assets under that tag are the v0.1.0 binaries, so their 42 downloads are downloads of the app as it then stood and belong to v0.1.0. Filtering on GitHub's flag would silently drop them, which is precisely why the flag is not used. No behaviour changes and no number moves: the badge still reads 240, and the tag rule gives the right answer for all eight tags. What changes is that a reader who checks the claim now finds it true. STATS.md also gains the per-release breakdown, because "four releases" beside a CSV listing five tags is the confusion this correction exists to prevent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126Pv8GFR6dszndiaG58D4G
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#447 selects stable tags by the absence of a
-in the tag rather than by GitHub'sprereleaseflag, and justified it by saying the flag is set on v0.1.1 by mistake. It is not.That tag is titled "v0.1.1 draft", its body calls it experimental, and it was never published as a release: this project has shipped four, v0.1.0, v0.1.2, v1.0.0 and v1.0.1.
The real reason is the stronger one. All three assets under that tag are the v0.1.0 binaries, so their 42 downloads are downloads of the app as it then stood and belong to v0.1.0. Filtering on GitHub's flag would silently drop them, which is precisely why the flag is not used.
No behaviour changes and no number moves: the badge still reads 240, and the tag rule gives the right answer for all eight tags. What changes is that a reader who checks the claim now finds it true.
STATS.md also gains the per-release breakdown, because "four releases" beside a CSV listing five tags is the confusion this correction exists to prevent.
Claude-Session: https://claude.ai/code/session_0126Pv8GFR6dszndiaG58D4G
Why
What changes
How to test this
Starting state:
What must not have happened:
Risks and limitations
Related
Design decisions and alternatives considered
Review outcome (required — see AGENTS.md)
<previous SHA> → <current SHA>checked; re-review outcomeImplementation notes
Screenshots or recording