[Push] Resume local-file pushes from receiver-confirmed cursors#367
Merged
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
6.35 s | 6.05 s | ⚪ +296 ms (+4.9%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
2.48 s | 2.46 s | ⚪ +25 ms (+1.0%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 8.83 s | 8.51 s | ⚪ +321 ms (+3.8%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
adamziel/push-files-sender
branch
4 times, most recently
from
July 18, 2026 10:57
2799a4b to
7e1c9a5
Compare
adamziel
force-pushed
the
adamziel/push-files-sender
branch
from
July 18, 2026 11:56
7e1c9a5 to
93e7125
Compare
adamziel
force-pushed
the
adamziel/push-files-sender
branch
2 times, most recently
from
July 18, 2026 13:30
1f8c861 to
3ee6a4e
Compare
adamziel
force-pushed
the
adamziel/push-files-sender
branch
from
July 18, 2026 13:37
3ee6a4e to
a595d9c
Compare
adamziel
force-pushed
the
adamziel/push-files-sender
branch
from
July 18, 2026 22:57
218819c to
e014b28
Compare
adamziel
force-pushed
the
adamziel/push-files-sender
branch
from
July 18, 2026 22:58
e014b28 to
038cfab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PushFilesSender, a resumable processor that turns a completed local-files plan into a committed push.Background
#366 made local-files planning resumable, but stopped at the two path lists. Sending those paths can span multiple PHP processes and cannot assume enough time or memory to finish in one run. A request may also end after the target accepted complete parts but before the sender received its response.
This change
start()owns the completed fresh local index and acquires the sender lock. Eachnext_step()call processes at most one planning path, one file chunk, one deleted path, or one lifecycle transition. Multipart requests may span calls. When the caller stops,cancel()abandons the open request at the preceding durable boundary andclose()releases resources and the lock without finishing it. After reopening, the target's cursors determine which bytes were accepted.The completed deletion plan is sent without re-reading the fresh local index or checking the live local tree. A path that reappears after planning belongs to the next push. File uploads still check type, size, and ctime around each read so a resumed upload cannot combine bytes from different file versions.
After the target commits the work, the fresh local index becomes the local index at the previous push and the planning files are removed.
Commit
068e025cis the last version before the processor refactor. This stack currently ends at3e2c4b1e.Usage
Start after producing a complete fresh local index. A later process resumes the same sender from
sender.json:completeends the push.restartmeans the caller must produce another fresh local index and callstart()again.failedreports its classification and explanation throughget_reason()andget_detail(); the same durable sender state remains available to a laterresume()call.Testing
There is no command integration for this processor yet. Review the interruption and continuation tests and rely on CI.