Copy: make strings reported in #479 translatable

[kmfoysal06]

Fixes #479 by wrapping the untranslated text string in the __() translation helper.

Closes #479

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @tapheret2.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kmfoysal06, priethor, mkismy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[tapheret2]

Review notes on “hotfix: translation issue #479”

Touched files (1): includes/fields/class-acf-field-select.php
Diff size (approx): +1 / -1

• Change set is focused. I don’t see an obvious correctness red flag from the diff alone.

Questions / nits

• Does this need a changelog / release note entry for the target version?
• Any user-facing behavior change that should be called out in the PR body?

Thanks @kmfoysal06 for the contribution — left this as an independent review pass.

[kmfoysal06]

Thanks @tapheret2 for the review! This doesn't introduce any functional behavior changes. The only user-facing difference is that the previously hardcoded string is now translatable and will appear correctly in localized installs.

[priethor]

Hi @tapheret2,

Thanks for the interest in SCF; it's always good to see more eyes on the PRs.

One thing we’ve noticed, though: the same layout and the same general questions come up across quite a few unrelated PRs, which tends to add more noise than signal. A review that isn’t tied to the specific diff doesn’t give us much to act on. Here, for example, the PR description already explains the user-facing effect (it makes a hardcoded string translatable), so the questions were pretty much answered already.

If something concrete in a diff looks off, we’d genuinely like to hear it. Otherwise, there’s really no need to leave a review just to leave one. Thanks for understanding.

[priethor]

Thanks @kmfoysal06! Looks good.

One catch before it goes in: the string is hardcoded in a few other field types too, and #479 calls out the User field specifically, so this on its own won’t close it. Could you grab these while you’re at it?

• class-acf-field-user.php
• class-acf-field-post_object.php
• class-acf-field-page_link.php

Same fix as here, and we’re good to go. 🙂

[kmfoysal06]

@priethor Thanks for the review! Sure, I’ll update those field types as well and push the changes shortly.

[kmfoysal06]

@priethor Hello, I just pushed the updates for the remaining files you mentioned. I also confirmed that those files don't have any other missing translatable strings.

[priethor]

Thanks, looks good to me. The Archive rename is slightly out of scope, but it's a good fix nevertheless.

[kmfoysal06]

@priethor Thanks for taking the time to review the PR and for the approval. I really appreciate it!

[priethor]

Thank you for contributing!