Backport: ACF 6.8.6 changes#504
Open
ockham wants to merge 2 commits into
Open
Conversation
Ports the ACF 6.8.6 point release (2026-07-14) into SCF:
- Location rules: guard against missing rule value/operator keys to
avoid PHP warnings (includes/locations/*).
- Admin: add acf-admin-7-0 body class on WP 7.0+ and port the improved
URL/Number/Select field appearance CSS.
- Blocks auto inline editing: only substitute placeholder values for
fields fetched against the block's own post id, and save/restore the
render context so nested block renders don't clobber the parent.
- WC orders: skip the ACF_Form_Post save for order post types so fields
save correctly with HPOS in compatibility mode (adapted to cover all
registered WooCommerce order types).
- Validation JS: scope submit-click validation to the button's own form
so unrelated UI (e.g. the Classic Editor link inserter) no longer
triggers premature validation; use validity.valid instead of
checkValidity() to avoid dispatching native invalid events.
- Blocks V2/V3 JS: don't crash on attribute values that merely start
with "[" or "{" (e.g. oEmbed titles) by try/catching JSON.parse;
updated jsx-parser tests to the new non-throwing behavior.
- Blocks V3 JS: deserialize Google Map field values after
acf.serialize() so they aren't double-encoded in block attributes.
- Bump DOMPurify 3.3.0 -> 3.4.11 to match upstream.
Intentionally not ported: the ACF email opt-in marketing banner
(admin-email-opt-in-banner.php, its view, JS, CSS, and images),
readme/version bumps, and lang/** translation churn.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports the ACF 6.8.6 point release (2026-07-14) into SCF. Upstream range: ACF
6.8.5 → 6.8.6(ACF 6.8.5 was verified to be fully covered already by earlier SCF work: #462, #467, #491 and related commits).All seven changelog fixes from upstream are included:
value/operatorkeys to avoid PHP warnings on page load (includes/locations/*). Ported from the free ACF repo (canonical for non-Pro files).acf-admin-7-0body class and port the improved URL/Number/Select field CSS. SCF's sass entries are flattened, so the CSS went intoacf-input.scssusing upstream's compiled output. The.acf-urlicon hunk was skipped — already fixed by #499 UI: Align URL Field Globe Icon Inside the URL Input Box. #500.includes/blocks-auto-inline-editing.php; the stale, unloadedpro/copy is untouched).acf/form-post/skip_savesosave_order()stays the single save entry-point and the backfill-triggeredsave_postno longer consumes the ACF nonce. Adapted to cover all registered order types viawc_get_order_types(), matching SCF's existing multi-order-type support.validity.validinstead ofcheckValidity()to avoid dispatching nativeinvalidevents.[or{(e.g. oEmbed titles) —JSON.parseis now try/caught in both the V2 parser (_acf-blocks.js) and V3 (jsx-parser.js). Two jsx-parser tests asserting the old throwing behavior were updated.acf.serialize()so they aren't double-encoded in block attributes (block-edit.js).The two block fixes only ship minified upstream; both bundle versions were pretty-printed and diffed (a string-literal set comparison confirmed these were the only substantive changes), then implemented in maintainable source — no decompiled output was pasted.
Intentionally not ported: the ACF email opt-in marketing banner (admin page, view, JS, CSS, images — collects emails for ACF's newsletter, not applicable to SCF), readme/version bumps, and
lang/**translation churn (SCF has its own translation workflow).Testing
php -lclean on all changed PHP files;npm run buildpasses (DOMPurify 3.4.11 bundles cleanly)post-type-admin.spec.ts×3,block-bindings-site-editor.spec.ts×1) reproduce identically on trunk and are unrelated to this PRUse of AI Tools
This PR was created with assistance from Claude Code (Anthropic).
🤖 Generated with Claude Code